ghost/core/core/server/services/gifts/gift-bookshelf-repository.ts (2)

3-4: Consider simplifying redundant type aliases.

Per static analysis, BookshelfModelInstance and BookshelfOptions are just aliases for unknown. While they add semantic intent, they could be inlined for simplicity.

Proposed simplification

-type BookshelfModelInstance = unknown;
-type BookshelfOptions = unknown;
-type BookshelfModel<T extends BookshelfModelInstance> = {
-    add(data: Partial<T>, unfilteredOptions?: BookshelfOptions): Promise<T>;
-    findOne(data: Record<string, unknown>, unfilteredOptions?: BookshelfOptions): Promise<T | null>;
+type BookshelfModel<T> = {
+    add(data: Partial<T>, unfilteredOptions?: unknown): Promise<T>;
+    findOne(data: Record<string, unknown>, unfilteredOptions?: unknown): Promise<T | null>;
 };

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@ghost/core/core/server/services/gifts/gift-bookshelf-repository.ts` around
lines 3 - 4, Remove the two redundant type aliases BookshelfModelInstance and
BookshelfOptions (both aliased to unknown) and inline unknown where they are
used, or replace their usages with the concrete/appropriate type if available;
update the file's type annotations referencing BookshelfModelInstance and
BookshelfOptions (e.g., function signatures, variable declarations) to use
unknown (or the real type) and delete the type alias declarations to simplify
the code.

---

12-17: Mark #Model as readonly.

The private field is never reassigned after construction.

Proposed fix

 export class GiftBookshelfRepository {
-    `#Model`: GiftBookshelfModel;
+    readonly `#Model`: GiftBookshelfModel;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@ghost/core/core/server/services/gifts/gift-bookshelf-repository.ts` around
lines 12 - 17, The private field `#Model` in class GiftBookshelfRepository is
never reassigned after construction; mark it readonly to reflect immutability.
Update the field declaration in GiftBookshelfRepository to be readonly (e.g.,
readonly `#Model`: GiftBookshelfModel) and ensure the constructor still assigns
this.#Model = GiftModel and that no other code reassigns `#Model`. This change
targets the private field named `#Model` and the constructor parameter GiftModel
in the GiftBookshelfRepository class.

ghost/core/core/server/services/gifts/gift.ts (1)

3-4: Consider exporting the type aliases for external use.

GiftStatus and GiftCadence types are defined but not exported. If other modules need to reference these types (e.g., for type-safe status checks or API contracts), consider adding the export keyword.

♻️ Optional: Export type aliases

-type GiftStatus = 'purchased' | 'redeemed' | 'consumed' | 'expired' | 'refunded';
-type GiftCadence = 'month' | 'year';
+export type GiftStatus = 'purchased' | 'redeemed' | 'consumed' | 'expired' | 'refunded';
+export type GiftCadence = 'month' | 'year';

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@ghost/core/core/server/services/gifts/gift.ts` around lines 3 - 4, The type
aliases GiftStatus and GiftCadence are currently module-private; export them so
other modules can import and use these types. Update the declarations for the
identifiers GiftStatus and GiftCadence to be exported (add the export keyword)
so they are available for external type-safe checks and API contracts, and
ensure any existing imports are updated to reference the exported types.

ghost/core/core/server/services/gifts/gift-service.ts (2)

22-29: Mark private fields as readonly.

Both #giftRepository and #memberRepository are only assigned in the constructor and never reassigned. Marking them as readonly improves type safety and documents intent.

♻️ Proposed fix

 export class GiftService {
-    `#giftRepository`: GiftBookshelfRepository;
-    `#memberRepository`: MemberRepository;
+    readonly `#giftRepository`: GiftBookshelfRepository;
+    readonly `#memberRepository`: MemberRepository;
 
     constructor({giftRepository, memberRepository}: {giftRepository: GiftBookshelfRepository; memberRepository: MemberRepository}) {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@ghost/core/core/server/services/gifts/gift-service.ts` around lines 22 - 29,
GiftService’s private fields `#giftRepository` and `#memberRepository` are only set
in the constructor and should be marked readonly to express immutability; update
the class field declarations for `#giftRepository` and `#memberRepository` to
include readonly (while keeping their types GiftBookshelfRepository and
MemberRepository) so the constructor remains the sole assignment point
(constructor({giftRepository, memberRepository}) assigns them as before).

---

31-36: Use Number.parseInt and Number.isNaN for modern best practices.

The global parseInt and isNaN functions work here, but the Number.* equivalents are preferred: Number.parseInt is explicit about namespace, and Number.isNaN avoids type coercion pitfalls.

♻️ Proposed fix

     async recordPurchase(data: GiftPurchaseData): Promise<boolean> {
-        const duration = parseInt(data.duration);
+        const duration = Number.parseInt(data.duration, 10);
 
-        if (isNaN(duration)) {
+        if (Number.isNaN(duration)) {
             throw new errors.ValidationError({message: `Invalid gift duration: ${data.duration}`});
         }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@ghost/core/core/server/services/gifts/gift-service.ts` around lines 31 - 36,
In recordPurchase, replace the global calls with the Number namespace: use
Number.parseInt(data.duration, 10) to parse the duration (explicit radix) and
check the result with Number.isNaN(duration) instead of isNaN; update the error
branch to use the new checks so the ValidationError is thrown when
Number.isNaN(duration) is true.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

ghost/core/core/server/services/gifts/gift-service.ts (1)

32-32: Specify radix for parseInt to avoid ambiguity.

Number.parseInt(data.duration) without a radix can behave unexpectedly with certain string formats (e.g., leading zeros in some engines historically treated as octal). While modern JavaScript defaults to base 10, explicitly specifying the radix is a defensive best practice.

Suggested fix

-        const duration = Number.parseInt(data.duration);
+        const duration = Number.parseInt(data.duration, 10);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@ghost/core/core/server/services/gifts/gift-service.ts` at line 32, The
parseInt call in gift-service.ts uses Number.parseInt(data.duration) without a
radix; update the parsing of the duration (the const duration assignment) to
explicitly specify the base (e.g., use radix 10) so the conversion is
unambiguous (replace Number.parseInt(data.duration) with an explicit-radix
parseInt call and keep any existing null/undefined handling around the duration
variable).

ghost/core/core/server/services/gifts/gift-service.ts (1)

31-40: Specify radix for parseInt to avoid ambiguity.

Number.parseInt without a radix can lead to unexpected behavior with leading zeros (e.g., '08' in older environments). Explicitly pass 10 as the radix for decimal parsing.

Proposed fix

-        const duration = Number.parseInt(data.duration);
+        const duration = Number.parseInt(data.duration, 10);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@ghost/core/core/server/services/gifts/gift-service.ts` around lines 31 - 40,
In recordPurchase (gift-service.ts) the call to Number.parseInt(data.duration)
omits a radix; update it to parse the duration as base 10 by calling
Number.parseInt(data.duration, 10) (or otherwise parse as decimal) so inputs
like "08" are handled consistently; ensure this change is applied inside the
recordPurchase method before the NaN check that throws the ValidationError.

ghost/core/core/server/services/gifts/gift-bookshelf-repository.ts (1)

25-47: Return type mismatch: declared Promise<unknown> but returns Promise<void>.

The method awaits this.#Model.add(...) but doesn't return its result, so it actually returns Promise<void>. The declared return type should match.

Proposed fix

-    async create(gift: Gift) {
+    async create(gift: Gift): Promise<void> {
         await this.#Model.add({

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@ghost/core/core/server/services/gifts/gift-bookshelf-repository.ts` around
lines 25 - 47, The create method declares it returns Promise<unknown> but
currently awaits this.#Model.add(...) and does not return its result (so it
returns Promise<void>); update the method to either return the result of
this.#Model.add(...) (i.e., add a return before this.#Model.add(...) in the
create function) or change the declared return type to Promise<void> to match
behavior; locate the create method in gift-bookshelf-repository (method name:
create) and make the return-type and actual return consistent.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes